Do you know the shipmonk dead code detector lib @staabm ?
Any clue why it triggers new errors about unrelated files on such PR ?

Edit: Maybe @janedbal you'll know ?

IIRC there is a open issue in which ondrej comments that we don't want base64 decoding because its a waste of resources

IIRC there is a open issue in which ondrej comments that we don't want base64 decoding because its a waste of resources

This was implemented by the bot in #5866 because of the Static Analysis failures to ensure those call are not false

But I think the workaround with base64 can be removed #5869

Do you know the shipmonk dead code detector lib @staabm ?
Any clue why it triggers new errors about unrelated files on such PR ?

Because PHPStan uses base64 encoding as obfuscation hack in

• src/Analyser/NodeScopeResolver.php:2624
• src/Reflection/BetterReflection/BetterReflectionProvider.php:148

Those places were previously basically new $unknown() which causes all constructors to be marked as used. Now that base64 is understood, it resolves to specific class and it starts reporting unused constructors all over the codebase (as there is no other wildcard constructor usage anymore).

Oh ! Thanks for the explanation